mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41299: Allow DockerContainerizer log to console.
Date Mon, 14 Dec 2015 19:28:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41299/#review110290
-----------------------------------------------------------


FYI, I'm making conflicting changes as part of work on a "logging module".  I published an
incomplete patch so you can see the conflicts:
https://reviews.apache.org/r/41294/


src/slave/containerizer/docker.cpp (lines 835 - 854)
<https://reviews.apache.org/r/41299/#comment170106>

    There's also some output in [src/docker/executor.cpp](https://github.com/apache/mesos/blob/dc6cde747eec94ba35aae5f5587d80338c000068/src/docker/executor.cpp#L141-L150).


- Joseph Wu


On Dec. 12, 2015, 9:35 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41299/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 9:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: MESOS-4141
>     https://issues.apache.org/jira/browse/MESOS-4141
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow DockerContainerizer log to console.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d

>   src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
>   src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c

>   src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 
>   src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187 
>   src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
> 
> Diff: https://reviews.apache.org/r/41299/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message