mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.
Date Sat, 12 Dec 2015 23:11:44 GMT


> On Dec. 10, 2015, 2:48 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, lines 27-29
> > <https://reviews.apache.org/r/39583/diff/4/?file=1125977#file1125977line27>
> >
> >     Let's move this into `<stout/error.hpp>`

Per discussion we actually move the error type to errorbase.hpp, and then have error.hpp #include
both `errorbase.hpp` and `windows/error.hpp`.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39583/#review109665
-----------------------------------------------------------


On Dec. 12, 2015, 11:08 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39583/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 11:08 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4110
>     https://issues.apache.org/jira/browse/MESOS-4110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added `WindowsError` to parallel `ErrnoError`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am a25e2c1e5584e744c666bbc654eafbfc5f7b10e6

>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 605c23bb9273f12dabbd2d6fa87ca0b06d9958ca

>   3rdparty/libprocess/3rdparty/stout/include/stout/errorbase.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 9e3b007d9f8db1e16c1f6928d85c230612741cc0

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39583/diff/
> 
> 
> Testing
> -------
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message