mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41166: Logger Module: Adds the ContainerLogger as a component for the containerizer and explicitly disallow use of the ContainerLogger with the External Containerizer.
Date Sat, 12 Dec 2015 00:39:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41166/
-----------------------------------------------------------

(Updated Dec. 11, 2015, 4:39 p.m.)


Review request for mesos, Benjamin Hindman and Artem Harutyunyan.


Changes
-------

Rename from ExecutorLogger to ContainerLogger.


Summary (updated)
-----------------

Logger Module: Adds the ContainerLogger as a component for the containerizer and explicitly
disallow use of the ContainerLogger with the External Containerizer.


Bugs: MESOS-4088
    https://issues.apache.org/jira/browse/MESOS-4088


Repository: mesos


Description (updated)
-------

Changes the factory methods and constructors for the `Containerizer` interface and the `MesosContainerizer`
to accept an `ContainerLogger`.

The `ExternalContainerizer` is not supported at the moment and is explicitly disallowed, so
that there are no incorrect assumptions.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.hpp 6964d136818ea9904fa35cd778eb9ef19e2c64fc 
  src/slave/containerizer/containerizer.cpp dcdf98fea4ca6f96658886db5d09c99f3bff501d 
  src/slave/containerizer/mesos/containerizer.hpp ab87cbcc843b471c7931aa38a590896f97be9865

  src/slave/containerizer/mesos/containerizer.cpp 6dad2e858b68cf47e048d49d34af4fa4cb3b6841


Diff: https://reviews.apache.org/r/41166/diff/


Testing
-------

This is tested later in the review chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message