mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.
Date Fri, 11 Dec 2015 21:54:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/#review110025
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 20)
<https://reviews.apache.org/r/39620/#comment169780>

    We can pull this directory include out below.


- Joris Van Remoortere


On Dec. 11, 2015, 8 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39620/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 8 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Included headers to make `stout/windows.hpp` standalone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 9f846738da95d7a32eb6aea2eea16f58af4cfebd

> 
> Diff: https://reviews.apache.org/r/39620/diff/
> 
> 
> Testing
> -------
> 
> `make check` from CMake on OS X 10.10.
> `make check` from Autotools on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu
box to test this from Ubuntu
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message