mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.
Date Fri, 11 Dec 2015 20:58:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review110020
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 71 - 72)
<https://reviews.apache.org/r/39559/#comment169775>

    Let's seed this with std::random_device inline.


- Joris Van Remoortere


On Dec. 11, 2015, 8:10 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 8:10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4108
>     https://issues.apache.org/jira/browse/MESOS-4108
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 03e6f75850561b5eb92da4771fbe18e4057ad520

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 99e0ae40971bd547dc55c42c090df4206cd41a17

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp e2d7424d01b8076c584370ac7c628284ca7ae54f

> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message