mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Klues" <klue...@gmail.com>
Subject Re: Review Request 41244: Use 'git rev-parse --git-dir' in post-reviews.py
Date Fri, 11 Dec 2015 20:18:16 GMT


> On Dec. 11, 2015, 7:05 p.m., Joseph Wu wrote:
> > LGTM!  Double-checked that `post-reviews.py` correctly rebases amended commits.
> > 
> > --- 
> > 
> > Can you also add `hartem` and `vinodkone` to this review?

Added


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41244/#review109988
-----------------------------------------------------------


On Dec. 11, 2015, 4:52 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41244/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 4:52 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4125
>     https://issues.apache.org/jira/browse/MESOS-4125
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The post-reviews.py script has similar problems to the bootstrap script
> in assuming that .git is a folder in the top-level directory of the git
> repo.  This may not be true when mesos is included as a submodule in
> another project. Use 'git rev-parse --git-dir' instead.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e 
> 
> Diff: https://reviews.apache.org/r/41244/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message