mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Review Request 41268: Avoided passing a negative error code to exit(3).
Date Fri, 11 Dec 2015 20:04:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41268/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-2209
    https://issues.apache.org/jira/browse/MESOS-2209


Repository: mesos


Description
-------

POSIX does not allow negative error codes, and they cause problems in practice
with some shells (e.g., Dash).


Diffs
-----

  src/exec/exec.cpp 8d064feb1b225741003db3492aa52b913419b46d 
  src/python/cli/src/mesos/cli.py 857059e2c12ed7f1419dfbf0d11dda0ff9fae235 

Diff: https://reviews.apache.org/r/41268/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message