mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41236: Some consistency style fixes in Docker puller.
Date Fri, 11 Dec 2015 19:02:06 GMT


> On Dec. 11, 2015, 6:41 p.m., Ben Mahler wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, lines 174-175
> > <https://reviews.apache.org/r/41236/diff/1/?file=1159661#file1159661line174>
> >
> >     This should be a 4 space indent rather than 2, but why bother wrapping on the
next line? Looks like both styles are ok here, so I assume you're going for consistency with
the code in this area.

Used 4 space indent. The wrapping is just for consistency in this file.


> On Dec. 11, 2015, 6:41 p.m., Ben Mahler wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, lines 159-160
> > <https://reviews.apache.org/r/41236/diff/1/?file=1159661#file1159661line159>
> >
> >     I find it easier to read when the closing ' is on the same line, for example:
> >     
> >     ```
> >         return Failure("Failed to create rootfs path '" + localRootfsPath + "'"
+
> >                        ": " + mkdir.error());
> >     ```

Done.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41236/#review109979
-----------------------------------------------------------


On Dec. 11, 2015, 2:01 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41236/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 2:01 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Some consistency style fixes in Docker puller.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 4aa4a9c4074d96c30c3bceea59d071feeecae2ea

> 
> Diff: https://reviews.apache.org/r/41236/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message