mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 41234: Close leaked FD in RegistryClientTest.SimpleRegistryPuller.
Date Fri, 11 Dec 2015 18:28:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41234/#review109977
-----------------------------------------------------------

Ship it!



src/tests/containerizer/provisioner_docker_tests.cpp (line 1195)
<https://reviews.apache.org/r/41234/#comment169713>

    This is good for now. But we will be still leaking fd if `ASSERT_SOME(os::nonblock(fd.get()));`
fails or `io::read` fails. The correct solution is to use a RAII pattern for file descriptors.
We can address that later.
    
    Also (not yours), I am not sure why we cannot use os::read here.


- Jie Yu


On Dec. 11, 2015, 6:21 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41234/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 6:21 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-4026
>     https://issues.apache.org/jira/browse/MESOS-4026
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Close leaked FD in RegistryClientTest.SimpleRegistryPuller.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2

> 
> Diff: https://reviews.apache.org/r/41234/diff/
> 
> 
> Testing
> -------
> 
> make check 
> 
> bin/mesos-tests.sh --gtest_filter="RegistryClientTest.SimpleRegistryPuller" --gtest_repeat=256
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message