mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
Date Fri, 11 Dec 2015 18:11:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39621/
-----------------------------------------------------------

(Updated Dec. 11, 2015, 6:11 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

CMake: Corrected linking path for gmock libraries on Windows builds.


Diffs
-----

  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 6eda46b0e08829b269b13a78f22510e6d03940d9


Diff: https://reviews.apache.org/r/39621/diff/


Testing
-------

`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.

PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu
box to test this from Ubuntu


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message