mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <>
Subject Re: Review Request 40759: Command executor can overcommit the slave
Date Fri, 11 Dec 2015 14:06:05 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 11, 2015, 10:06 p.m.)

Review request for Ben Mahler, Guangya Liu, Artem Harutyunyan, Ian Downes, Joris Van Remoortere,
Joseph Wu, and Vinod Kone.


Ready for review after test passed

Summary (updated)

Command executor can overcommit the slave

Bugs: MESOS-1718

Repository: mesos


Currently we give a small amount of resources to the command executor, in addition to resources
used by the command task:

ExecutorInfo Slave::getExecutorInfo(
    const FrameworkID& frameworkId,
    const TaskInfo& task)
    // Add an allowance for the command executor. This does lead to a
    // small overcommit of resources.
          "cpus:" + stringify(DEFAULT_EXECUTOR_CPUS) + ";" +
          "mem:" + stringify(DEFAULT_EXECUTOR_MEM.megabytes())).get());

This leads to an overcommit of the slave. Ideally, for command tasks we can "transfer" all
of the task resources to the executor at the slave / isolation level.

Diffs (updated)

  include/mesos/mesos.proto 8ca2130 
  src/launcher/executor.cpp 09e7de6 
  src/master/constants.hpp cc38dfc 
  src/master/master.hpp 9aa548a 
  src/master/master.cpp 0d14822 
  src/master/validation.cpp 6a43bce 
  src/slave/constants.hpp bcbb140 
  src/slave/slave.hpp b7586ce 
  src/slave/slave.cpp 9bd86e1 
  src/tests/containerizer/docker_containerizer_tests.cpp 3f199e6 
  src/tests/master_tests.cpp 865fa4a 
  src/tests/master_validation_tests.cpp fbf8fad 
  src/tests/monitor_tests.cpp a848d14 
  src/tests/reservation_endpoints_tests.cpp d5d2aa7 
  src/tests/slave_recovery_tests.cpp c0e4ff7 
  src/tests/slave_tests.cpp 4975bea 


Testing (updated)

`make && make check` in OS


Klaus Ma

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message