mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian Qiu" <qiuj...@cn.ibm.com>
Subject Re: Review Request 40469: Update Allocator interface to support dynamic weight
Date Fri, 11 Dec 2015 10:01:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40469/#review109938
-----------------------------------------------------------



include/mesos/role/role.hpp (line 24)
<https://reviews.apache.org/r/40469/#comment169655>

    namespace mesos?


- Jian Qiu


On Dec. 11, 2015, 9 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40469/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2015, 9 a.m.)
> 
> 
> Review request for mesos, Adam B, Guangya Liu, Neil Conway, Qian Zhang, and Jian Qiu.
> 
> 
> Bugs: MESOS-3956
>     https://issues.apache.org/jira/browse/MESOS-3956
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, RoleInfo protobuf never be used for serialization, so I think we can remove
it from allocator.proto, and define a struct to communicate between the allocator and master.
But for role information display, then current serialization way(call modle(role*) in http.cpp)
is not better, and we should define another RoleInfo protobuf for serialization. Refer to
other components(such as quota), I propose to define role protobuf in a separated package
rather than define it in mesos.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 
>   include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c 
>   include/mesos/role/role.hpp PRE-CREATION 
>   include/mesos/role/role.proto PRE-CREATION 
>   src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/master/allocator/mesos/allocator.hpp 97ee80726ad155917811265a983258b0165d3451 
>   src/master/allocator/mesos/hierarchical.hpp 99c742906874c30c39c159e58a65277ade3c07fd

>   src/master/allocator/mesos/hierarchical.cpp 5da825a1d578a9ee40b4985378fddb3c5fb3b416

>   src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab

>   src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824

>   src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
>   src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4 
>   src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 
>   src/tests/hierarchical_allocator_tests.cpp e239b4746494fcc2b362a83afb634a2ce5e25f9b

> 
> Diff: https://reviews.apache.org/r/40469/diff/
> 
> 
> Testing
> -------
> 
> Make successfully.
> Make check successfully.
> Run test framework successfully
> 
> TODO: will add a test for role update.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message