mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Review Request 41211: Aggregated Http as member in Master.
Date Thu, 10 Dec 2015 17:32:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41211/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Before this change the Http object was copied in to each HTTP routing
lambda. If state were to be introduced, this could create hard to
debug issues. Aggregating a single instance as a member of Master
prevents these issues and simplifies access to communal code paths
such as `authenticate`.


Diffs
-----

  src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
  src/master/master.cpp 7acdc0a5d23a606eac2f37f4b7dd021c5a4fceb7 

Diff: https://reviews.apache.org/r/41211/diff/


Testing
-------

make check


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message