mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 41185: CMake: Updated LFLAG for dl library to defined label
Date Thu, 10 Dec 2015 15:57:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41185/#review109764
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 114)
<https://reviews.apache.org/r/41185/#comment169397>

    One could argue that this flag should be defined twice, once for Stout and once for Process.
We have done stuff like that in the past, but I think here it's a bit too much of a nit even
for a pedant like me. :)


- Alex Clemmer


On Dec. 10, 2015, 3:26 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41185/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 3:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Updated LFLAG for dl library to defined label
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 9893d741cd7c611dc65eba76be03e06dac618132

> 
> Diff: https://reviews.apache.org/r/41185/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message