mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 39043: Added support for HTTP Authentication in Mesos.
Date Thu, 10 Dec 2015 14:34:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
-----------------------------------------------------------

(Updated Dec. 10, 2015, 3:34 p.m.)


Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till Toenshoff.


Changes
-------

Updates for changes in previous reviews.


Bugs: MESOS-3756
    https://issues.apache.org/jira/browse/MESOS-3756


Repository: mesos


Description
-------

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP authenticator with
the libprocess one.
4. Updates one test which expected the wrong results since now credentials are checked before
the body of the request.


Diffs (updated)
-----

  src/master/constants.hpp cc38dfcf57ecbc8555379084acbf2bfa4b3fc759 
  src/master/constants.cpp 98ea7c8f1e7c3057cfe941f82f1b71f7731a8f32 
  src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 
  src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 
  src/master/http.cpp 5d33138d60e684b23f07e1781de7991209d3e161 
  src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 
  src/master/master.cpp 7acdc0a5d23a606eac2f37f4b7dd021c5a4fceb7 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message