mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.
Date Thu, 10 Dec 2015 00:54:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review109646
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/Makefile.am (lines 67 - 68)
<https://reviews.apache.org/r/39559/#comment169238>

    alphabetic



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 85 - 86)
<https://reviews.apache.org/r/39559/#comment169239>

    alphabetic.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 47 - 48)
<https://reviews.apache.org/r/39559/#comment169245>

    indentation.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 65 - 68)
<https://reviews.apache.org/r/39559/#comment169247>

    rand() won't be threadsafe.
    Let's use stout's thread_locals and do something like:
    ```
    static THREAD_LOCAL std::mt19937 generator;
    int index = generator() % maxAlphabetIndex;
    ```



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 77)
<https://reviews.apache.org/r/39559/#comment169248>

    Can we call this variable `mkdir`?


- Joris Van Remoortere


On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 9:13 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am a8c35c086ecae21701f6a720f25231c1b0d4e329

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d

> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message