mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.
Date Thu, 10 Dec 2015 00:10:18 GMT


> On Dec. 3, 2015, 5:10 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/include/process/http.hpp, line 582
> > <https://reviews.apache.org/r/40905/diff/2/?file=1152942#file1152942line582>
> >
> >     hmmm , why do we need another constructor with no response body ?
> >     
> >     We have already seen previous bugs from end-users about us not setting `Content-Type`
for some error `Response` types like `BadRequest`. Hence, empty body responses should be avoided
at best unless I am missing something ?

I followed the pattern we use for other response types. I think we should clean it up at once
in a separate patch.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40905/#review108845
-----------------------------------------------------------


On Dec. 3, 2015, 2:34 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40905/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 2:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4056
>     https://issues.apache.org/jira/browse/MESOS-4056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> According to RFC 2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7),
`MethodNotAllowed` response must include an 'Allow' header containing a list of valid methods.
> 
> This is a libprocess change only.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp c7d19a2086a8891d0198dce1c4d1c92bd99ac6e3

> 
> Diff: https://reviews.apache.org/r/40905/diff/
> 
> 
> Testing
> -------
> 
> This a libprocess change only. The code does not compile without the follow-up [mesos]
patch https://reviews.apache.org/r/40913/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message