mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.
Date Wed, 09 Dec 2015 23:36:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41156/
-----------------------------------------------------------

(Updated Dec. 9, 2015, 11:36 p.m.)


Review request for mesos, Michael Park, Neil Conway, and Till Toenshoff.


Changes
-------

Expanded the scope of the patch, updated summary and description, +MPark.


Summary (updated)
-----------------

Employed a better macro in tests, cleaned up formatting.


Repository: mesos


Description (updated)
-------

Replaced all instances of `AWAIT_EXPECT_EQ({true|false}, ...)` with more appropriate `AWAIT_EXPECT_{TRUE|FALSE}(...)`.
Also wrapped typenames in backticks in "authorization_tests.cpp".


Diffs (updated)
-----

  src/tests/authorization_tests.cpp 32beeea3584f093bcac24e0c160235de0e3abb28 
  src/tests/group_tests.cpp 9db6162dae0a2657e12f4e99334f9cab65d14e9a 

Diff: https://reviews.apache.org/r/41156/diff/


Testing (updated)
-------

`GTEST_FILTER="*AuthorizationTest*:*GroupTest*" make check -j7` on Mac OS 10.10.4


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message