mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 41096: Added LFLAGs need for linux cmake build
Date Wed, 09 Dec 2015 18:01:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41096/#review109569
-----------------------------------------------------------



3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (line 102)
<https://reviews.apache.org/r/41096/#comment169145>

    Oh, this is good. In `StoutTestsConfigure`, we're manually including the dl flag, you
should replace that with this infinitely superior solution. :)


- Alex Clemmer


On Dec. 9, 2015, 3:37 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41096/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 3:37 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added LFLAGs need for linux cmake build
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake a9cd9902567cef4c7ab4125463a68e19907db0b4

> 
> Diff: https://reviews.apache.org/r/41096/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message