mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory
Date Wed, 09 Dec 2015 17:59:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41108/#review109566
-----------------------------------------------------------



src/slave/cmake/SlaveConfigure.cmake (line 39)
<https://reviews.apache.org/r/41108/#comment169139>

    I suspect this works on your machine because curl is on your include path somewhere, but
in general, we want to add `${CURL_INCLUDE_DIR}` tot this code for when it's not.



src/slave/cmake/SlaveConfigure.cmake (line 62)
<https://reviews.apache.org/r/41108/#comment169140>

    Same comment about the include directories, but with libraries. We probably want to include
`CURL_LIBS` here.



src/slave/cmake/SlaveConfigure.cmake (line 85)
<https://reviews.apache.org/r/41108/#comment169142>

    Per our convention in other configure files, we tend to put platform-conditional include
and lib definitions near their original blocks. That is, we'd move the `if (LINUX)` include
block to be just under the first definition of `PROCESS_INCLUDE_DIR`, and so on.



src/slave/cmake/SlaveConfigure.cmake (line 86)
<https://reviews.apache.org/r/41108/#comment169141>

    Do we not need SASL, cURL, and DL for OS X? Looking at `StoutTestsConfigure`, it looks
like we do.


- Alex Clemmer


On Dec. 8, 2015, 11:09 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41108/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 11:09 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add curl, sasl and dl link flags and add protobuf library directory
> 
> 
> Diffs
> -----
> 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41108/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message