mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 41090: Second iteration of changes for cmake build on linux.
Date Wed, 09 Dec 2015 17:34:51 GMT


> On Dec. 8, 2015, 6:18 p.m., Joseph Wu wrote:
> > src/slave/cmake/FindCurl.cmake, line 28
> > <https://reviews.apache.org/r/41090/diff/2/?file=1156045#file1156045line28>
> >
> >     (I'm a bit of a CMake noob.)  Where is this defined?

`find_package` is a built-in, and when you define a macro with the name `FindX.cmake`, you
automatically get the ability to type `find_package(X)` for free.

Gross or neat, depending on your perspective. :)


> On Dec. 8, 2015, 6:18 p.m., Joseph Wu wrote:
> > src/slave/cmake/FindCurl.cmake, line 92
> > <https://reviews.apache.org/r/41090/diff/2/?file=1156045#file1156045line92>
> >
> >     Where was this variable defined/declared/documented?

This is part of the `find_package` API, _cf_.[1] If you look down for the string `_FIND_QUIETLY`
you can find the documentation.

https://cmake.org/cmake/help/v3.0/command/find_package.html


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41090/#review109354
-----------------------------------------------------------


On Dec. 9, 2015, 3:45 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41090/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 3:45 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Second iteration of changes for cmake build on linux.
> 
> 
> Diffs
> -----
> 
>   src/slave/cmake/FindCurl.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41090/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message