mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 40056: Make hook execution order deterministic.
Date Wed, 09 Dec 2015 17:26:53 GMT


> On Dec. 4, 2015, 9:15 p.m., Niklas Nielsen wrote:
> > Hi Haosdent!
> > 
> > I apologize the tardy reply. The patch looks good but needs rebasing.
> > Also, have you thought of a way to test this?
> > 
> > With a test (maybe by just ensuring the existing ordering of the test modules are
indeed run in order), we should be able to land this. Kapil, any concerns on this?
> 
> Guangya Liu wrote:
>     @nnielsen, does this test help? Thanks! https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp#L93-L106
> 
> Niklas Nielsen wrote:
>     That should be fine - rebase and let's get it in. (Kapil, any objections?)

Thx @gyliu and @nnielsen, let me rebase.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40056/#review109028
-----------------------------------------------------------


On Dec. 9, 2015, 5:25 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40056/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 5:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kapil Arya, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3485
>     https://issues.apache.org/jira/browse/MESOS-3485
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Make hook execution order deterministic.
> 
> 
> Diffs
> -----
> 
>   src/hook/manager.cpp efbb02561afbabcc451aafdcf204b1fe478f2677 
> 
> Diff: https://reviews.apache.org/r/40056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message