mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41092: Added CMake file for agent executable build.
Date Wed, 09 Dec 2015 03:30:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109357
-----------------------------------------------------------


Initial review.  I haven't run this code yet.

---

What do you think about using "agent" in the variable names and comments?


src/slave/CMakeLists.txt (line 39)
<https://reviews.apache.org/r/41092/#comment168847>

    Nit: trim this line.



src/slave/CMakeLists.txt (line 42)
<https://reviews.apache.org/r/41092/#comment168978>

    The pre-commit hooks will complain about this line.


- Joseph Wu


On Dec. 8, 2015, 9:57 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message