mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian Qiu" <qiuj...@cn.ibm.com>
Subject Re: Review Request 40224: Fix wrong flags infos in /state and /flags
Date Wed, 09 Dec 2015 02:20:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/
-----------------------------------------------------------

(Updated Dec. 9, 2015, 2:20 a.m.)


Review request for mesos, Ben Mahler and haosdent huang.


Bugs: MESOS-3792
    https://issues.apache.org/jira/browse/MESOS-3792


Repository: mesos


Description
-------

Fix wrong flags infos in /state and /flags. We should convert protobuf type flag to JSON object
explicitly instead of relying on stringify


Diffs (updated)
-----

  src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 
  src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116 

Diff: https://reviews.apache.org/r/40224/diff/


Testing
-------

make & make check

./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": [{"principals": {
"type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": [{"principals": { "values": ["a",
"b"] },"users": { "values": ["c"] }}],"shutdown_frameworks": [{"principals": { "values": ["a",
"b"] },"framework_principals": { "values": ["c"] }}]}'

curl http://master:5050/state
curl http://master:5050/flag


Thanks,

Jian Qiu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message