mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 40995: Added test cases for role behavior.
Date Tue, 08 Dec 2015 19:15:51 GMT


> On Dec. 8, 2015, 2:55 p.m., Alexander Rukletsov wrote:
> > One thing we also agreed is to disallow empty string roles. Do you think it makes
sense to extend this patch with a test for that or do it separately?

I think we should do this separately, perhaps as part of fixing MESOS-2210.


> On Dec. 8, 2015, 2:55 p.m., Alexander Rukletsov wrote:
> > src/tests/role_tests.cpp, line 36
> > <https://reviews.apache.org/r/40995/diff/3/?file=1155872#file1155872line36>
> >
> >     I believe we use third person singular in such cases.

Fixed.


> On Dec. 8, 2015, 2:55 p.m., Alexander Rukletsov wrote:
> > src/tests/role_tests.cpp, lines 76-77
> > <https://reviews.apache.org/r/40995/diff/3/?file=1155872#file1155872line76>
> >
> >     I think a comment here expaining why you reduce the allocation interval will
be good for posterity. Alternatively, you can use `Clock::advance(flags.allocation_interval)`
before `AWAIT_READY(offers)` to achieve the same. Perhaps it's a cleaner solution.

Yeah, it would probably be cleaner to use `advance` instead of reducing the allocation interval
(although that applies to many other tests as well). I'll take a look at doing that.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109324
-----------------------------------------------------------


On Dec. 8, 2015, 8:28 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40995/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 8:28 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Yong Qiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for role behavior.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 
>   src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40995/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message