mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41090: Second iteration of changes for cmake build on linux.
Date Tue, 08 Dec 2015 18:28:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41090/#review109360
-----------------------------------------------------------



src/slave/cmake/FindCurl.cmake (line 111)
<https://reviews.apache.org/r/41090/#comment168848>

    This patch doesn't apply:
    ```
    2015-12-08 10:25:51 URL:https://reviews.apache.org/r/41090/diff/raw/ [4071/4071] ->
"41090.patch" [1]
    41090.patch:117: new blank line at EOF.
    +
    warning: 1 line adds whitespace errors.
    src/slave/cmake/FindCurl.cmake:111: new blank line at EOF.
    ```
    
    (You should only leave one newline at the EOF, not two.)


- Joseph Wu


On Dec. 8, 2015, 9:52 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41090/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 9:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Second iteration of changes for cmake build on linux.
> 
> 
> Diffs
> -----
> 
>   src/slave/cmake/FindCurl.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41090/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message