mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41090: Second iteration of changes for cmake build on linux.
Date Tue, 08 Dec 2015 18:18:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41090/#review109354
-----------------------------------------------------------


Initial review.  I haven't applied/tested this patche yet.
---
I'd recommend re-wording your summary (the title of this review) to reflect the contents.
 When we look back at the git history, I'm pretty sure the order of commits won't matter as
much as a concise summary.
Something like: `CMake: Add FindCurl macro`


src/slave/cmake/FindCurl.cmake (line 1)
<https://reviews.apache.org/r/41090/#comment168836>

    Nit: Missing a space here.



src/slave/cmake/FindCurl.cmake (lines 18 - 22)
<https://reviews.apache.org/r/41090/#comment168838>

    s/IMPORTANT NOTE:/**NOTE:**/
    
    Also, you don't need to block-indent the subsequent lines.



src/slave/cmake/FindCurl.cmake (line 28)
<https://reviews.apache.org/r/41090/#comment168843>

    (I'm a bit of a CMake noob.)  Where is this defined?



src/slave/cmake/FindCurl.cmake (line 92)
<https://reviews.apache.org/r/41090/#comment168844>

    Where was this variable defined/declared/documented?



src/slave/cmake/FindCurl.cmake (line 103)
<https://reviews.apache.org/r/41090/#comment168845>

    Nit: extra space at end.


- Joseph Wu


On Dec. 8, 2015, 9:52 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41090/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 9:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Second iteration of changes for cmake build on linux.
> 
> 
> Diffs
> -----
> 
>   src/slave/cmake/FindCurl.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41090/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message