mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 40995: Added test cases for role behavior.
Date Tue, 08 Dec 2015 03:16:31 GMT


> On 十二月 8, 2015, 12:51 a.m., Guangya Liu wrote:
> > src/tests/role_tests.cpp, lines 24-27
> > <https://reviews.apache.org/r/40995/diff/1/?file=1154161#file1154161line24>
> >
> >     I think that we should always use std first?
> >     
> >     using std::vector;
> >     
> >     using process::Future;
> >     using process::PID;
> 
> Neil Conway wrote:
>     All the test cases I looked at place `process` before `std`: e.g., `fault_tolerance_tests.cpp`,
`master_tests.cpp`, `reservation_tests.cpp`.

I think that there are bugs here, you can also refer to master_quota_test.cpp , I recalled
that I discussed with alex-mesos for this issue and his comments is we should put std first.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109234
-----------------------------------------------------------


On 十二月 7, 2015, 9:22 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40995/
> -----------------------------------------------------------
> 
> (Updated 十二月 7, 2015, 9:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Yong Qiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for role behavior.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 
>   src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40995/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message