mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 41042: Added description of the LoadQoSController in the oversubscription.md
Date Tue, 08 Dec 2015 02:40:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review109256
-----------------------------------------------------------


Bad patch!

Reviews applied: [40617]

Failed command: ./support/apply-review.sh -n -r 40617

Error:
 2015-12-08 02:40:27 URL:https://reviews.apache.org/r/40617/diff/raw/ [16256/16256] ->
"40617.patch" [1]
Successfully applied: Added Load QoS Controller for simple eviction when system load is above
configured threshold.

Added Load QoS Controller for the simple eviction when system load is above configured system
load threshold for 5min and 15min:
- Made os::loadavg called from the lambda and passed via the contructor.
- Added unit test.


Review: https://reviews.apache.org/r/40617
src/slave/qos_controllers/load.cpp:1:  A license header should appear on the file's  first
line starting with '// Licensed'.: /**
Total errors found: 1
Checking 3 files
Failed to commit patch

- Mesos ReviewBot


On Dec. 7, 2015, 5:18 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 5:18 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-4076
>     https://issues.apache.org/jira/browse/MESOS-4076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added description to _Writing a custom QoS controller_ and _Configuring  oversubscription_
sections.
> 
> 
> Diffs
> -----
> 
>   docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f 
> 
> Diff: https://reviews.apache.org/r/41042/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message