mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 40951: Initial set of source files missing for cmake agent binary.
Date Mon, 07 Dec 2015 22:35:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109206
-----------------------------------------------------------

Ship it!



src/CMakeLists.txt (line 222)
<https://reviews.apache.org/r/40951/#comment168680>

    Perhaps there should be a blank line above this block?



src/CMakeLists.txt (lines 224 - 227)
<https://reviews.apache.org/r/40951/#comment168681>

    Our list style is: if a list append can fit on one line, we usually try to fit it.



src/CMakeLists.txt (line 269)
<https://reviews.apache.org/r/40951/#comment168683>

    Our style is: we don't put a space between `set` and `(`.



src/CMakeLists.txt (lines 274 - 280)
<https://reviews.apache.org/r/40951/#comment168685>

    Hmm, I might be crazy, but does `isolators` come before `linux_launcher`? :)



src/CMakeLists.txt (line 289)
<https://reviews.apache.org/r/40951/#comment168686>

    There's an extra newline here.


- Alex Clemmer


On Dec. 5, 2015, 3:35 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> -------
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message