mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 41046: Made v1 API in mesos.proto equivalent to non-v1.
Date Mon, 07 Dec 2015 22:20:58 GMT


> On Dec. 7, 2015, 9:32 p.m., Till Toenshoff wrote:
> > include/mesos/v1/mesos.proto, line 1506
> > <https://reviews.apache.org/r/41046/diff/2/?file=1155254#file1155254line1506>
> >
> >     I must be missing something, but where did index 6 go?

Appears to be a bug in Mesos master, filed https://issues.apache.org/jira/browse/MESOS-4091.

Given that we want to create parity, I think leaving this in for the HTTP API makes sense
so it gets solved for V0 and V1 together, if needed.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41046/#review109190
-----------------------------------------------------------


On Dec. 7, 2015, 6:28 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41046/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 6:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Copied all missing feature updates (and 1 comment, all verbatim) to v1 from include/mesos.proto
in these RRs:
> https://reviews.apache.org/r/31915
> https://reviews.apache.org/r/38253
> https://reviews.apache.org/r/38367
> https://reviews.apache.org/r/38367
> https://reviews.apache.org/r/37307/
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/41046/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message