mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 32505: Added SHUTDOWN scheduler call.
Date Mon, 07 Dec 2015 21:19:47 GMT


> On Nov. 20, 2015, 6:36 p.m., Zhitao Li wrote:
> > src/master/master.cpp, line 3498
> > <https://reviews.apache.org/r/32505/diff/5/?file=939961#file939961line3498>
> >
> >     Hi [~vinodkone], can you please explain what it takes to "repliabily forward"
this message? Do you mean we should perform some kind of retry action, or send this message
at a different message path?
> >     
> >     I'm working on [MESOS-313](https://issues.apache.org/jira/browse/MESOS-313)
and would like to get it to the last mile.
> >     
> >     Thanks!

I haven't thought through on how to solve this yet, but yes, there needs to be some kind of
retry and acknowledgement mechanism involved.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32505/#review107389
-----------------------------------------------------------


On April 22, 2015, 9:41 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32505/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 9:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1127 and MESOS-330
>     https://issues.apache.org/jira/browse/MESOS-1127
>     https://issues.apache.org/jira/browse/MESOS-330
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a new call added to explicitly shutdown an executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 
>   src/master/master.hpp 550d2c50cd01aa5830a7e7e03ab4a0240c221b15 
>   src/master/master.cpp f3462d15005e24ab28e8265484b0d3810f21bd47 
>   src/messages/messages.proto bdf474b6614fad6eebdd79c636e820f9c30cf0c9 
>   src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a 
>   src/slave/slave.hpp d214ddb168298071dd90ad6d7f9bc6fd3d78d986 
>   src/slave/slave.cpp 60345ec0d05a8150e61d71a6510824a7f2ca9524 
>   src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 
> 
> Diff: https://reviews.apache.org/r/32505/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message