mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bartek Plotka" <>
Subject Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.
Date Mon, 07 Dec 2015 15:02:34 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 7, 2015, 3:02 p.m.)

Review request for mesos and Niklas Nielsen.


- Added few descriptions and comments.
- Moved wrapping function to c++11 lambda.
- Removed simple typedef.
- Moved isstring to numify.
- Added proper unit test.

Repository: mesos


Added Load QoS Controller for the simple eviction when system load is above configured threshold:
- Made os::loadavg called from internal method. This method is then passed as lambda to the
Load QoS Controller process.
- Added MockLoadQoSController
- Added tests

Tests still WIP.

Diffs (updated)

  src/ a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/slave/qos_controllers/load.hpp PRE-CREATION 
  src/slave/qos_controllers/load.cpp PRE-CREATION 
  src/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b 



make check


Bartek Plotka

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message