mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.
Date Sat, 05 Dec 2015 05:45:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41001/#review109081
-----------------------------------------------------------


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On Dec. 5, 2015, 12:37 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41001/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2015, 12:37 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved 'ReservationTest.ACLMultipleOperations'.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 
> 
> Diff: https://reviews.apache.org/r/41001/diff/
> 
> 
> Testing
> -------
> 
> `GTEST_FILTER="ReservationTest.ACLMultipleOperations" bin/mesos-tests.sh --gtest_repeat=1000
--gtest_break_on_failure`
> 
> This test was originally written to test the interaction of multiple RESERVE/UNRESERVE/LAUNCH
operations in a single `acceptOffers()` call when authorization is enabled. In order to probe
the effect of authorization on this interaction, some operations should fail due to failed
authorization. However, this test included operations that failed simply because they were
malformed. I altered the test so that now operations will fail due to failed authorization,
which tests the desired functionality in a more thorough way.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message