mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Review Request 40987: Fix apply-reviews.py to work for first-time contributors.
Date Fri, 04 Dec 2015 21:30:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40987/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Repository: mesos


Description
-------

`apply-reviews.py` does `git commit --author 'NAME'`.  This only works for contributors that
have contributed before.

`apply-review.sh` does `git commit --author 'NAME <EMAIL>'` which works for first-time
contributors too.


Diffs
-----

  support/apply-reviews.py f6c05be77bcf963c5aa6036a4660296d390bd475 

Diff: https://reviews.apache.org/r/40987/diff/


Testing
-------

`support/apply-reviews.py -n -r 40951`

^ Should not complain with:
```
fatal: --author 'Diana Arroyo' is not 'Name <email>' and matches no existing author
```


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message