mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song" <songzihao1...@gmail.com>
Subject Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.
Date Fri, 04 Dec 2015 19:07:00 GMT


> On Dec. 4, 2015, 10:46 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/message.proto, line 68
> > <https://reviews.apache.org/r/40944/diff/3/?file=1154022#file1154022line68>
> >
> >     Might be easy to read/understand if we name the fields as rawV1CompatibilityString
and the the actual parsed field as v1Compatibility to match their semantics.

In order to make use of protobuf::parse, we must have protobuf msg name exactly matched as
JSON field. And that is the reason why we have below comments for vaCompat optional field.
:)


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review109010
-----------------------------------------------------------


On Dec. 4, 2015, 11:01 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 11:01 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 824a788af0d2c779a2ca82a69ba65b6361154038

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 89f61c20e52e5eff8d8e92748f03b3b461516cd2

>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e

>   src/tests/containerizer/provisioner_docker_tests.cpp c63bf53fee40ef12536a16e11f4d5224c4e4278e

> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message