mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 40954: Fix comments in TaskHealthStatus message proto.
Date Fri, 04 Dec 2015 18:12:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40954/#review109005
-----------------------------------------------------------

Ship it!



src/messages/messages.proto (line 666)
<https://reviews.apache.org/r/40954/#comment168418>

    Typo: s/on each receive. If/On each receive, if/
    
    Suggestion: s/the health check program failed consecutively that/the number of consecutive
failed health checks/



src/messages/messages.proto (line 667)
<https://reviews.apache.org/r/40954/#comment168419>

    Suggestion: insert "the" before "`kill_task`".



src/messages/messages.proto (line 678)
<https://reviews.apache.org/r/40954/#comment168420>

    Typo: s/failure/failures/


- Joseph Wu


On Dec. 3, 2015, 9:44 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40954/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 9:44 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix comments in TaskHealthStatus message proto.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.proto 178d757a76f14829da6daab97ec678843717cf5a 
> 
> Diff: https://reviews.apache.org/r/40954/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message