mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <>
Subject Re: Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.
Date Fri, 04 Dec 2015 00:17:26 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 4, 2015, 12:17 a.m.)

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Fix another instance of the `send(); Clock::settle();` pattern in the same test.

Bugs: MESOS-4059

Repository: mesos


There were two problems:

(1) After launching two tasks, we assumed that we would see TASK_RUNNING updates
    for the tasks in the same order they were launched. This is not guaranteed,
    so adjust the test to handle TASK_RUNNING updates in the order they are

(2) The test used this pattern:

        Mesos m;
        Call c;

        // Trigger a new batch allocation that reflects the call

    However, this is actually unsafe (see MESOS-3760): the send() call might not
    have reached the master by the time `Clock::settle()` happens. This was
    fixed by blocking using `FUTURE_DISPATCH` on the downstream logic in the
    allocator that is invoked to handle the delivered event.

Diffs (updated)

  src/tests/master_maintenance_tests.cpp 00900561a1b8dd03a7a2f3d60a036b4beb920aa1 



./src/mesos-tests --gtest_filter="MasterMaintenanceTest.InverseOffersFilters" --gtest_repeat=2000
# on OSX
./src/mesos-tests --gtest_filter="MasterMaintenanceTest.InverseOffersFilters" --gtest_repeat=100
 # on Ubuntu Wily (slow VM)


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message