mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 40797: Filtered non-whitelisted and deactivated agents once per allocation.
Date Thu, 03 Dec 2015 20:07:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40797/#review108875
-----------------------------------------------------------

Ship it!



src/master/allocator/mesos/hierarchical.cpp (lines 1086 - 1097)
<https://reviews.apache.org/r/40797/#comment168340>

    Let's simplify this to a basic for loop with a condition.
    We can add an abstraction to stout to do something like filter later.


- Joris Van Remoortere


On Nov. 30, 2015, 5:14 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40797/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 5:14 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e

> 
> Diff: https://reviews.apache.org/r/40797/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message