mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 40445: Added linter for license headers in some file types.
Date Thu, 03 Dec 2015 09:30:02 GMT


> On Dec. 3, 2015, 3:51 a.m., Michael Park wrote:
> > support/mesos-style.py, lines 152-153
> > <https://reviews.apache.org/r/40445/diff/7/?file=1151867#file1151867line152>
> >
> >     Why not `print`?

Using `print "foo"`-style now (for local consistency).


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108772
-----------------------------------------------------------


On Dec. 3, 2015, 9:29 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 9:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
>     https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> -------
> 
> Ran the a whole clean checkout through the linter with only one expected failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto`
which lacks a license).
> 
> 
> NOTE TO THE COMMITTER
> ---------------------
> 
> Before committing this, it is probably a good idea to check the whole code base again
and fix any new files which do not follow the current license style. The commits which originally
fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message