mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API
Date Wed, 02 Dec 2015 22:29:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38878/#review108731
-----------------------------------------------------------



src/tests/executor_http_api_tests.cpp (line 749)
<https://reviews.apache.org/r/38878/#comment168186>

    s/on/by/



src/tests/executor_http_api_tests.cpp (line 757)
<https://reviews.apache.org/r/38878/#comment168195>

    Hmm. this test is a bit convoluted. you start a pid based executor first, wait for its
update to be received by the scheduler and then start a subscribe request from http executor?
    
    i'm assuming you can't simply send a subscribe request because the slave wouldn't have
an executor struct in its map. is it possible to stop the pid executor from starting at all?
maybe by using testing isolator/containerizer?


- Vinod Kone


On Nov. 30, 2015, 3:56 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38878/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 3:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
>     https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a basic test to validate the implementation for Subscribe->Subscribed
workflow on the `api/v1/executor` endpoint on Agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/executor_http_api_tests.cpp fe9df1f4d68babaf0960a3b689ffbe60704b8ad5 
> 
> Diff: https://reviews.apache.org/r/38878/diff/
> 
> 
> Testing
> -------
> 
> make check. Would add more agent recovery tests/executor reconnect tests in a separate
patch.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message