mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
Date Wed, 02 Dec 2015 20:02:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review108704
-----------------------------------------------------------


Some minor comments modulo comments from Bernd earlier.


src/tests/reservation_tests.cpp (line 205)
<https://reviews.apache.org/r/40731/#comment168166>

    Is this comment needed ?



src/tests/reservation_tests.cpp (line 222)
<https://reviews.apache.org/r/40731/#comment168165>

    Can we just do:
    
    `EXPECT_CALL(sched, resourceOffers(&driver, _))
         .WillOnce(FutureArg<1>(&offers));`
         
    This is more in sync with the style followed in the rest of the tests. Can we modify the
other ocurrences in this test too ?



src/tests/reservation_tests.cpp (line 254)
<https://reviews.apache.org/r/40731/#comment168164>

    We generally avoid redundant/self-explanatory comments. Is this really needed at all ?
What is it trying to convey ?



src/tests/reservation_tests.cpp (line 261)
<https://reviews.apache.org/r/40731/#comment168163>

    Not yours : Can we insert an additional line here. We leave 2 lines after each global
function/test.


- Anand Mazumdar


On Dec. 2, 2015, 8:27 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:27 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp e7f14079e766ce0a8bad2da646776347e4a17169 
> 
> Diff: https://reviews.apache.org/r/40731/diff/
> 
> 
> Testing
> -------
> 
> Ran make check after adding Mandeep's test case to the GTEST framework.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message