mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39989: [5/5] Added framework authorization for dynamic reservation.
Date Wed, 02 Dec 2015 16:05:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39989/#review108654
-----------------------------------------------------------



src/master/master.cpp (lines 3029 - 3030)
<https://reviews.apache.org/r/39989/#comment168114>

    Blank line? Here and below



src/master/master.cpp (lines 3032 - 3034)
<https://reviews.apache.org/r/39989/#comment168115>

    We validate later on that in `principal` is `None`, reserve is aborted. IIUC, if `FrameworkInfo`
does not specify principal, it cannot reserve resources. So the question is: do we need to
check this first and only then proceed with authz?



src/master/master.cpp (line 3180)
<https://reviews.apache.org/r/39989/#comment168117>

    s/Testing/Test for consistency, here and below.


- Alexander Rukletsov


On Dec. 2, 2015, 9:41 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39989/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 9:41 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added framework authorization for dynamic reservation.
> Note: this review is continued from https://reviews.apache.org/r/37127/
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821 
>   src/tests/reservation_tests.cpp 15d180f92ec0aea99e6f3a7d0b505c62bd207b61 
> 
> Diff: https://reviews.apache.org/r/39989/diff/
> 
> 
> Testing
> -------
> 
> This is the fifth in a chain of 5 patches. New reservation tests were added to `reservation_tests.cpp`
to validate the authentication of framework reserve and unreserve operations using ACLs. `make
check` was run to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message