mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39987: [3/5] Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.
Date Wed, 02 Dec 2015 14:17:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39987/#review108638
-----------------------------------------------------------


A drive-by review, I'm looking into authz and ACLs and learning from your patches.


src/master/master.cpp (line 2775)
<https://reviews.apache.org/r/39987/#comment168095>

    I believe you inherited the TODO from MPark. Do you want to preserve his name or change
to yours?



src/master/master.cpp (line 2781)
<https://reviews.apache.org/r/39987/#comment168094>

    Maybe "' to reserve any resources"? Or mention what resources are allowed to reserve (similar
to what you do in `authorizeUnreserveResources`.



src/master/master.cpp (lines 2811 - 2812)
<https://reviews.apache.org/r/39987/#comment168096>

    Fits one line (clang-format suggests the same).


- Alexander Rukletsov


On Dec. 2, 2015, 9 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39987/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 9 a.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve.
> Note: this review is continued from https://reviews.apache.org/r/37125/
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe 
>   src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821 
> 
> Diff: https://reviews.apache.org/r/39987/diff/
> 
> 
> Testing
> -------
> 
> This is the third in a chain of 5 patches. `make check` was used to test after all patches
were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message