mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 40445: Added linter for license headers in some file types.
Date Wed, 02 Dec 2015 11:18:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
-----------------------------------------------------------

(Updated Dec. 2, 2015, 11:18 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
-------

Moved license check into `mesos-style.py`.


Bugs: MESOS-3581
    https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
-------

Added linter for license headers in some file types.


Diffs (updated)
-----

  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
-------

Ran the a whole clean checkout through the linter with only one expected failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto`
which lacks a license).


NOTE TO THE COMMITTER
---------------------

Before committing this, it is probably a good idea to check the whole code base again and
fix any new files which do not follow the current license style. The commits which originally
fixed this were

* fa36917 (mesos),
* dc23756 (stout), and
* 3539b7a (libprocess).


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message