mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jian Qiu" <qiuj...@cn.ibm.com>
Subject Re: Review Request 40224: Fix wrong flags infos in /state and /flags
Date Wed, 02 Dec 2015 02:10:36 GMT


> On Nov. 23, 2015, 4:08 p.m., haosdent huang wrote:
> > I think keep the sync of these files when flags add or delete Protobuf fields a
bit hard. Is it possible to change flags stringify protobuf objects as json string

Thanks hasdent. I do not think we can overload or have a specialized stringify for google::protobuf::Message
since it is an abstract class. How about rewriting the operator<< overload for each
protobuf flag? We can change https://github.com/apache/mesos/blob/master/include/mesos/authorizer/authorizer.hpp#L138
to "return stream << JSON::protobuf(acls)". However, it still needs change for each
protobuf flag. Any thought?


- Jian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40224/#review107604
-----------------------------------------------------------


On Nov. 23, 2015, 5:56 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40224/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 5:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-3792
>     https://issues.apache.org/jira/browse/MESOS-3792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix wrong flags infos in /state and /flags. We should convert protobuf type flag to JSON
object explicitly instead of relying on stringify
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
> 
> Diff: https://reviews.apache.org/r/40224/diff/
> 
> 
> Testing
> -------
> 
> make & make check
> 
> ./mesos-master.sh --work_dir=/tmp/mesos --acls='{"register_frameworks": [{"principals":
{ "type": "ANY" },"roles": { "values": ["a"] }}],"run_tasks": [{"principals": { "values":
["a", "b"] },"users": { "values": ["c"] }}],"shutdown_frameworks": [{"principals": { "values":
["a", "b"] },"framework_principals": { "values": ["c"] }}]}'
> 
> curl http://master:5050/state
> curl http://master:5050/flag
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message