mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Pravat" <dpra...@outlook.com>
Subject Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`
Date Tue, 01 Dec 2015 20:38:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40114/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 8:38 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph
Wu.


Repository: mesos


Description
-------

Added Windows & Posix defines for several parameter list used in future.hpp. 
Provided a new parameter list for VC2015.
Move the existing parameter list into posix.hpp. 

The change has been due to: 

   1. VS 2015 won't support C++14 result_of SFINAE until Update 2,  so
      result_of must be replaced with decltype(invoke).
   2. VS 2015 won't support C++14 std::function SFINAE until Update 2, so
      converting _Deferred to std::function must be done by explicitly
      calling _Deferred's conversion function.
   3. The Standard (C++11 through 17) does not require bind's function call
      operator to SFINAE, and VS 2015's doesn't.  is_bind_expression can be
      used to manually reroute bind expressions to the 1-arg overload, where
      (conveniently) the argument will be ignored if necessary.


Diffs (updated)
-----

  3rdparty/libprocess/include/Makefile.am 47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/future.hpp c9146e3a3ccf09dd37c5a8ac7000fbe84f3c710c

  3rdparty/libprocess/include/process/posix/future.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/windows/future.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40114/diff/


Testing
-------

OSX make check, Windows 10 make, Ubuntu 15.1 make check


Thanks,

Daniel Pravat


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message