mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription
Date Tue, 01 Dec 2015 12:26:33 GMT


> On Dec. 1, 2015, 10:10 a.m., Joseph Wu wrote:
> > src/slave/slave.cpp, lines 4464-4466
> > <https://reviews.apache.org/r/40379/diff/3/?file=1138604#file1138604line4464>
> >
> >     Can you add a comment about why this is purposefully and unilaterally done here
(potentially overwriting what the ResourceEstimator has given you)?
> >     
> >     It may also be a good idea to update the documentation in "include/mesos/slave/resource_estimator.hpp".

Sure, I'll add some comments for it, for the document, can we address them in MESOS-3889?
There're two reason to add this code:
1. I'd like to `set_type()` accordingly, so we can make `RevocalbeInfo::type` to be `required`
2. I'd like `ResourceEstimator` return the right type


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40379/#review108440
-----------------------------------------------------------


On Nov. 25, 2015, 2:41 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40379/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 2:41 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, and Joseph
Wu.
> 
> 
> Bugs: MESOS-3930
>     https://issues.apache.org/jira/browse/MESOS-3930
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK for Oversubscription
and ALLOCATION_SLACK for Optimistic Offer. Slave helps to update `RevocableInfo::type` for
Oversubscription.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 9055f2a 
> 
> Diff: https://reviews.apache.org/r/40379/diff/
> 
> 
> Testing
> -------
> 
> make (make check is on-going)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message