mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 40706: Clarified a comment for `Accept` call.
Date Tue, 01 Dec 2015 12:18:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40706/#review108481
-----------------------------------------------------------



include/mesos/scheduler/scheduler.proto (line 229)
<https://reviews.apache.org/r/40706/#comment167939>

    Sorry to be nit-picky about such a trivial change, but could we keep this comment consistent
with other places (e.g. `include/mesos/scheduler.hpp`)?
    
    ```
    Available resources are aggregated when multiple offers are provided. Note that all offers
must belong to the same slave.
    ```
    
    Maybe we could just do:
    
    ```
    NOTE: All offers must belong to the same agent.
    ```


- Michael Park


On Nov. 30, 2015, 10:47 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40706/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 10:47 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 7bf447e07665dd33646edd0c684ab559712631cc 
> 
> Diff: https://reviews.apache.org/r/40706/diff/
> 
> 
> Testing
> -------
> 
> not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message