mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 40806: Made HDFS::exists asynchronous.
Date Tue, 01 Dec 2015 10:40:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40806/#review108475
-----------------------------------------------------------



src/hdfs/hdfs.cpp (line 82)
<https://reviews.apache.org/r/40806/#comment167934>

    s/exec/execute/
    
    'to exec' seems to indicate that the exec syscall failed. That may not always be the cause
for the failure.



src/hdfs/hdfs.cpp (line 100)
<https://reviews.apache.org/r/40806/#comment167933>

    This block seems to be reusable in a lot of situations. Any chance we could abstract it
and make it part of class Subprocess?
    
    In a separate ticket, I suppose. ==> Place a TODO here?


- Bernd Mathiske


On Nov. 30, 2015, 5:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40806/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 5:21 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made HDFS::exists asynchronous.
> 
> This also fixed a bug in the orignal code: the original code never returns false.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp ac933b6a8636af3356f3d6a99656c0185077c262 
>   src/hdfs/hdfs.hpp 6bdeedf8934a681b32fca8edc251488f4213dd07 
>   src/hdfs/hdfs.cpp c32c2ae9d2ace5deb09f56dcec2bd366c2d07f6b 
> 
> Diff: https://reviews.apache.org/r/40806/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message